Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Valset update slash event #125

Merged
merged 13 commits into from
Dec 11, 2023
Merged

Valset update slash event #125

merged 13 commits into from
Dec 11, 2023

Conversation

maurolacy
Copy link
Collaborator

@maurolacy maurolacy commented Dec 1, 2023

Slash amount computed based on historical validator power (for double signing misbehaviour) and sent to the virtual-staking contract for proper slashing amounts accounting.

TODO:

  • Better encapsulation, helpers, and data types (use Coin to send amounts to the contract, etc.)
  • Fix / adjust broken tests. (done)
  • Test slashing due to double signing.
  • Test slashing with an historical misbehaviour evidence explicitly.
  • Adjust for / improve rounding / conversion issues.

@maurolacy maurolacy requested review from alpe and pinosu December 1, 2023 11:11
@maurolacy maurolacy marked this pull request as ready for review December 10, 2023 10:36
Copy link
Contributor

@pinosu pinosu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@maurolacy maurolacy merged commit 7169d3b into main Dec 11, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants