Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(p2p): render HasChannel(chID) is a public p2p.Peer method (#… #142

Merged
merged 4 commits into from
Aug 19, 2024
Merged

feat(p2p): render HasChannel(chID) is a public p2p.Peer method (#… #142

merged 4 commits into from
Aug 19, 2024

Commits on Aug 19, 2024

  1. feat(p2p): render HasChannel(chID) is a public p2p.Peer method (c… 

    …ometbft#3510)

Closes: cometbft#3472

It also prevents reactors from starting routines intended to send
messages to a peer that does not implement/support a given channel.
Because all `Send()` or `TrySend()` calls from this routine will be
useless, always returning `false` and possibly producing some busy-wait
behavior (see cometbft#3414).

The changes are restricted to: mempool and evidence reactor, because
they use a single channel and have a sending routine peer peer, and two
of the consensus routines, for Data and Votes.

Block and State sync reactors have smarter ways to deal with
unresponsive peers, so probably this check is not needed.

---

- [x] Tests written/updated
- [x] Changelog entry added in `.changelog` (we use
[unclog](https://github.com/informalsystems/unclog) to manage our
changelog)
- [x] Updated relevant documentation (`docs/` or `spec/`) and code
comments
- [x] Title follows the [Conventional
Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec
    @cason @ValarDragon
    cason authored and ValarDragon committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    80f527f View commit details
    Browse the repository at this point in the history

  2. add changelog

    @ValarDragon
    ValarDragon committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    a1aa0d2 View commit details
    Browse the repository at this point in the history

  3. Fix build issue

    @ValarDragon
    ValarDragon committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    a5703cc View commit details
    Browse the repository at this point in the history

  4. Fix lint

    @ValarDragon
    ValarDragon committed Aug 19, 2024
    Configuration menu
    Copy the full SHA
    fa40306 View commit details
    Browse the repository at this point in the history