Commits on Aug 19, 2024

1. perf(p2p): Remove broadcast return channel (backport cometbft#3182) (c… …

   …ometbft#3480)
   
   Remove the return channel and waitgroup from switch.Broadcast as its
   unused. This was costing us some CPU overhead (2% of broadcast routine
   as it stands right now, but broadcast routine time should be dropping)
   and one extra goroutine. This removes more overhead than what cometbft#3180 may
   introduce.
   
   It also better highlights the point that maybe all broadcast usecases
   should consider using TrySend (And we potentially adapt channel
   buffers), ala the point in cometbft#3151 . (This would have significant
   system-wide impact, by significantly lowering the number of
   timers/scheduler overhead we have)
   
   ---
   
   - [x] Tests written/updated - Simplifies code, the behavior being
   removed was never tested!
   - [x] Changelog entry added in `.changelog` (we use
   [unclog](https://github.com/informalsystems/unclog) to manage our
   changelog)
   - [x] Updated relevant documentation (`docs/` or `spec/`) and code
   comments
   - [x] Title follows the [Conventional
   Commits](https://www.conventionalcommits.org/en/v1.0.0/) spec
   <hr>This is an automatic backport of pull request cometbft#3182 done by
   [Mergify](https://mergify.com).
   
   ---------
   
   Co-authored-by: Dev Ojha <[email protected]>
   Co-authored-by: Anton Kaliaev <[email protected]>

   

   3 people committed Aug 19, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for ab985f1
   • Browse repository at this point

   Copy the full SHA

   ab985f1 View commit details

   Browse the repository at this point in the history