Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stratos assets #1932

Merged
merged 1 commit into from
Oct 3, 2024
Merged

Conversation

BoThe1K
Copy link
Contributor

@BoThe1K BoThe1K commented Sep 30, 2024

Description

Checklist

Adding Assets

If adding a new asset, please ensure the following:

  • Asset is registered to the Cosmos Chain Registry.
  • Add asset to bottom of zone_assets.json.
    • chain_name and base_denom are provided and use values exactly as defined at the Chain Registry.
    • path is provided, and the IBC channel referenced is registered at the Chain Registry (unless native to Osmosis).
    • osmosis_verified is set to false
    • listing_date_time_utc is specified and accurate
    • Optional: transfer_methods, peg_mechanism, override_properties, canonical, categories, where necessary (see README for details).
  • I am aware that upgrading an asset to 'verified' status requires an additional PR to this repo (checklist below).

Adding Chains

If adding a new chain, please ensure the following:

  • Chain is registered to the Cosmos Chain Registry.
    • Chain's registration must have staking defined, with at least one staking_token denom specified.
    • Chain's registration must have fees defined; at least one fee token has low, average, and high gas prices defined.
  • IBC Connection between chain and Osmosis is registered.
  • Add chain to bottom of zone_chains.json
    • rpc and rest does not have any CORS blocking of the Osmosis domain, and RPC node has have WSS enabled.
    • explorer_tx_url correctly directs to the transaction when the hash is inserted into the URL.

@JeremyParish69
Copy link
Contributor

JeremyParish69 commented Oct 2, 2024

The validation failed because there aren't any fee rates defined at the Chain Registry
https://github.com/cosmos/chain-registry/blob/master/stratos/chain.json#L18-L24

@BoThe1K
Copy link
Contributor Author

BoThe1K commented Oct 2, 2024

The validation failed because there aren't any fee rates defined at the Chain Registry https://github.com/cosmos/chain-registry/blob/master/stratos/chain.json#L18-L24

thanks, have created PR: cosmos/chain-registry#5415

anything else we should add here or in chain-registry?

@JeremyParish69
Copy link
Contributor

Oh, the IBC connection between osmosis and stratos must be registered. There is a checklist item for this requirement.
https://github.com/cosmos/chain-registry/tree/master/_IBC

@BoThe1K
Copy link
Contributor Author

BoThe1K commented Oct 2, 2024

Oh, the IBC connection between osmosis and stratos must be registered. There is a checklist item for this requirement. https://github.com/cosmos/chain-registry/tree/master/_IBC

thanks, have created PR: cosmos/chain-registry#5418

@JeremyParish69
Copy link
Contributor

Looks like the check passed. I think the last required change is to resolve conflicts.

@JeremyParish69 JeremyParish69 merged commit 44e0106 into osmosis-labs:main Oct 3, 2024
4 checks passed
@BoThe1K
Copy link
Contributor Author

BoThe1K commented Oct 4, 2024

@JeremyParish69 I have a question. When we could see our asset on https://app.osmosis.zone/ (even as unverified through the settings filter)? (so when it will become available)

@JeremyParish69
Copy link
Contributor

@JeremyParish69 I have a question. When we could see our asset on https://app.osmosis.zone/ (even as unverified through the settings filter)? (so when it will become available)

Will need to submit to Osmosis Labs' assetlist https://github.com/osmosis-labs/assetlists?tab=readme-ov-file#how-to-add-assets

@BoThe1K
Copy link
Contributor Author

BoThe1K commented Oct 7, 2024

Hi @JeremyParish69 ! Even after #1940 , I do not see STOS in the pool creation or the swap (with unverified asset checkbox in the settings). Should we add something else for this?

Screenshot 2024-10-07 at 15 49 55 Screenshot 2024-10-07 at 15 51 43

@JeremyParish69
Copy link
Contributor

Hi @JeremyParish69 ! Even after #1940 , I do not see STOS in the pool creation or the swap (with unverified asset checkbox in the settings). Should we add something else for this?

No further action required. Updates to Osmosis Zone are delayed, but should be recovered soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants