Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missed UI for Uploading changes when "Offline editing" is Off #4088

Open
gy-mate opened this issue Nov 2, 2024 · 1 comment
Open

Missed UI for Uploading changes when "Offline editing" is Off #4088

gy-mate opened this issue Nov 2, 2024 · 1 comment
Assignees
Labels
Milestone

Comments

@gy-mate
Copy link

gy-mate commented Nov 2, 2024

  1. Open the sidebar > Plugins > OpenStreetMap Editing > cogwheel at the top right
  2. Turn off Offline editing
  3. Go back to the map
  4. Make an edit
  5. Upload it to OSM
  6. The changeset is uploaded without a comment. See https://www.openstreetmap.org/changeset/158592444 for example

I think that automatically adding a comment to the changeset (something like 'Deleted grit bin' in the case above) would make it more informative.

@gy-mate gy-mate changed the title Automatically add a changeset comment for deleted elements Automatically add changeset comments to online edits Nov 5, 2024
@gy-mate gy-mate changed the title Automatically add changeset comments to online edits Automatically add a changeset comment to online edits Nov 5, 2024
@vshcherb vshcherb added this to the 4.9-iOS milestone Nov 5, 2024
@dmpr0 dmpr0 changed the title Automatically add a changeset comment to online edits Missed UI for Uploading changes when "Offline editing" is Off Nov 5, 2024
@dmpr0
Copy link
Contributor

dmpr0 commented Nov 5, 2024

The issue is worse. After last redesign, we have lost UI that should be appeared to confirm uploading

ToDo

After tap on Apply we need to show Upload UI with Back button, that will allow to Upload changes or get back to change something.

Offline editing is Off

  • Tap Delete – show upload UI with Back button.
  • Tap Upload – show upload UI with Back button.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants