Skip to content

Commit

Permalink
Search page: Set HTML page title for structured searches, too
Browse files Browse the repository at this point in the history
  • Loading branch information
mtmail committed May 6, 2024
1 parent 437201f commit cf3e8f8
Show file tree
Hide file tree
Showing 3 changed files with 46 additions and 2 deletions.
2 changes: 2 additions & 0 deletions CHANGES.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
# CHANGES

* Search page: Set HTML page title for structured searches, too

* version 3.5.2 - 2024-04-05
* Detail page: Link to postcode search not includes the country code
* test-suite: fix typos based on a codespell run
Expand Down
13 changes: 11 additions & 2 deletions src/pages/SearchPage.svelte
Original file line number Diff line number Diff line change
Expand Up @@ -45,12 +45,21 @@
fetch_from_api('search', api_request_params, function (data) {
results_store.set(data);
update_html_title('Result for ' + api_request_params.q);
if (anyStructuredFieldsSet) {
update_html_title('Result for ' + [
api_request_params.street,
api_request_params.city,
api_request_params.county,
api_request_params.state,
api_request_params.country,
api_request_params.postalcode
].filter((text) => text && text.length > 1).join(', '));
document.querySelector(".nav-tabs a[href='#structured']").click();
document.querySelector('input[name=street]').focus();
} else {
update_html_title('Result for ' + api_request_params.q);
document.querySelector('input[name=q]').focus();
}
});
Expand Down
33 changes: 33 additions & 0 deletions test/search.js
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,39 @@ describe('Search Page', function () {
});
});

describe('Structured search for Paris', function () {
before(async function () {
page = await browser.newPage();
await page.goto('http://localhost:9999/search.html');
await page.click(".nav-link[href='#structured']");
// await page.screenshot({ path: "./screen.png", fullPage: true });
await page.type('input[name=city]', 'Paris');
await page.type('input[name=country]', 'USA');
await page.click('#structured button[type=submit]');
await page.waitForSelector('#searchresults');
});

after(async function () {
await page.close();
});

it('should have a HTML page title', async function () {
assert.equal(await page.title(), 'Result for Paris, USA | Nominatim Demo');
});

it('should have added search params', async function () {
let current_url = new URL(await page.url());
assert.strictEqual(current_url.searchParams.get('q'), null);
assert.strictEqual(current_url.searchParams.get('city'), 'Paris');
assert.strictEqual(current_url.searchParams.get('country'), 'USA');
});

it('should have at least one result', async function () {
let results_count = await page.$$eval('#searchresults .result', elements => elements.length);
assert.ok(results_count > 1);
});
});

describe('Search for OSM URL', function () {
before(async function () {
page = await browser.newPage();
Expand Down

0 comments on commit cf3e8f8

Please sign in to comment.