Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add data warn if frozen #3499

Merged
merged 1 commit into from
Aug 7, 2024
Merged

Conversation

mtmail
Copy link
Collaborator

@mtmail mtmail commented Aug 5, 2024

For #3494

$ nominatim import --osm-file country1.pbf --no-updates
$ nominatim add-data --file country2.pbf
Using project directory: /home/vagrant/nominatim-project
Database is marked frozen. New data can't be added.

The documentation seems to cover it already: Warning: The data structure for updates are also required when adding additional data after the import, for example [TIGER housenumber data](https://nominatim.org/release-docs/develop/customize/Tiger/). If you plan to use those, you must not use the --no-updates parameter. Do a normal import, add the external data and once you are done with everything run nominatim freeze.

I added a new pylint exception. Happy to restructure the code instead or limit the exception to just that file if you have ideas.

@mtmail mtmail requested a review from lonvia August 5, 2024 12:30
@mtmail mtmail force-pushed the add-data-warn-if-frozen branch from 5c14dd9 to f0390cf Compare August 5, 2024 14:14
@lonvia lonvia merged commit 738e99c into osm-search:master Aug 7, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants