Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various cleanups of BDD tests #3493

Merged
merged 8 commits into from
Jul 31, 2024
Merged

Various cleanups of BDD tests #3493

merged 8 commits into from
Jul 31, 2024

Conversation

lonvia
Copy link
Member

@lonvia lonvia commented Jul 31, 2024 •
edited
Loading

  • remove BUILDDIR parameter and use osm2pgsql in PATH instead, for tests with legacy tokenizer forcibly set -DSERVER_MODULE_PATH
  • remove support for coverage testing for PHP
  • fix some tests for the legacy tokenizer + Python frontend combination, mostly disabling the tests as it is not worth the effort to reinstate the behaviour. See commits for details.

Fixes #3469.

lonvia added 8 commits July 31, 2024 11:16
@lonvia
bdd tests: get rid of dependency on build path
474aea6 
BDD tests will now use whatever osm2pgsql they find in the PATH.
For testing against legacy tokenizer, use -DSERVER_MODULE_PATH
to point to the module. This will no longer work out of the box.
@lonvia
remove support for PHP code coverage in BDD tests
c8d4597
@lonvia
switch CI to new handling of legacy BDD tests
f5fd2f0
@lonvia
add forgotten BDD test
d47acbc
@lonvia
disable ZIP5+ test for Python frontend
2048009 
Currently not working.
@lonvia
make housenumber search work with non-indexed partials
cfe5284
@lonvia
fix postcode lookup with legacy tokenizer
a97bfaf
@lonvia
adapt BDD tests for legacy tokenizer + Python frontend
2914284 
Mostly disables the tests, the cases are not worth fixing anymore.
Others just avoid using terms that trigger abbreviations.
@lonvia lonvia merged commit a4d7cdd into osm-search:master Jul 31, 2024
11 checks passed
@lonvia lonvia deleted the clean-up-bdd-tests branch July 31, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

test suite assumes osm2psql located in build path
1 participant
@lonvia