Improve use of SQLAlchemy statement cache with search queries #3101
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SQLAlchemy has an internal statement cache which caches rendered SQL. This PR makes some changes to the code to make better use of this cache:
Also contains some changes to the debug output of SQL queries. It is notoriously hard to get inlining of bind parameters right for all supported versions SQLAlchemy and Python.
Reverse queries are 15-20% faster with the change. Search queries are around 5-7% faster on SQLAlchemy 2.
Note that SQLAlchemy 1.4 still has some issues with caching very large queries, which concerns all searches with a housenumber. Thus it tends to be quite worse for search performance. Given that the issue is gone in SQLAlchemy 2, I'm not going to dig into this more. It may go away anyway when starting to use SQLAlchemy lambdas, which is next on the list.