Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: pyos profile to cookie #273

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

lwasser
Copy link

@lwasser lwasser commented May 2, 2024

Pull Request description

This is a PR that adds a pyOpenSci profile to the osl cookiecutter!

How to test these changes

scicookie --profile pyos

Pull Request checklists

This PR is a:

  • bug-fix
  • new feature
  • maintenance

About this PR:

  • it includes tests.
  • the tests are executed on CI.
  • the tests generate log file(s) (path).
  • pre-commit hooks were executed locally.
  • this PR requires a project documentation update.

Author's checklist:

  • I have reviewed the changes and it contains no misspelling.
  • The code is well commented, especially in the parts that contain more
    complexity.
  • New and old tests passed locally.

Additional information

Reviewer's checklist

Copy and paste this template for your review's note:

## Reviewer's Checklist

- [ ] I managed to reproduce the problem locally from the `main` branch
- [ ] I managed to test the new changes locally
- [ ] I confirm that the issues mentioned were fixed/resolved

@xmnlab
Copy link
Member

xmnlab commented May 3, 2024

hey @lwasser , thanks for working on that!

I just fixed that issues you pointed me yesterday, and I cut a new release as well.
please, feel free to ping me anytime if you have any question, comment or recommendation :)

@xmnlab
Copy link
Member

xmnlab commented Oct 7, 2024

hi @lwasser !

just checking if you want to move this PR forward, if you want any help we can jump into a pair-review session and finish that together.

all the best,

@lwasser
Copy link
Author

lwasser commented Oct 7, 2024

oh gosh i forgot about this Ivan. Let's get something scheduled. i've been so busy.

@xmnlab
Copy link
Member

xmnlab commented Oct 25, 2024

Hi @lwasser , sure thing! that would be great! sorry for the delay here!

maybe we could schedule a meeting after the pyOS event :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants