Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refractor: change attribute shell to backend #114

Merged
merged 4 commits into from
Sep 25, 2024

Conversation

abhijeetSaroha
Copy link
Collaborator

Solves #110

@abhijeetSaroha
Copy link
Collaborator Author

Can you please review whenever you have time? @xmnlab

@abhijeetSaroha
Copy link
Collaborator Author

I have also updated the .github/workflow .yaml files. Is this okay or will it remain same like before?

@abhijeetSaroha
Copy link
Collaborator Author

I have reverted the changes to .github/workflow .yaml files.

@abhijeetSaroha
Copy link
Collaborator Author

To update the documentation, I found two files .ipynb in docs/tutorial, where shell needs to be changed to backend, but two more files changlog.md and xonsh.md , should I change too (I don't think so), can you please check it?

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@xmnlab xmnlab merged commit 7d617ce into osl-incubator:main Sep 25, 2024
14 checks passed
@xmnlab
Copy link
Member

xmnlab commented Sep 25, 2024

thanks for working on that @abhijeetSaroha

@abhijeetSaroha abhijeetSaroha deleted the refractor-shell-backend branch September 26, 2024 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants