-
-
Notifications
You must be signed in to change notification settings - Fork 373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust Nightly Build Settings (Pass 2) #1189
Conversation
Seems nightly build will create default tag, this tag will affect the release note which depends on last tag. https://github.com/ncipollo/release-action
If we can build nightly only when there are new commits, it's an improvement. |
@Bambooin The nightly build only run on schedule (specified at UTC 3:00 everyday), and only run when
trime/.github/workflows/nightly-ci.yml Line 10 in 924a14a
The tag only will be created when we specify one or the value of |
I mean release.yml, such that when we decide to release trime/.github/workflows/release-ci.yml Lines 70 to 81 in 30cb7c0
|
Just remove |
Hm, I'm too optimistic. If we don't specify tag or there is no valid git ref, the build will end up with failure. https://github.com/WhiredPlanck/trime-new/actions/runs/7600515837 |
So we have to find the workaroud on the nightly build without tag. |
@Bambooin Great news: I just find that mikepenz/release-changelog-builder-action actually has a input option called P.S. Before I discovered this option, I was struggling to write bash scripts to ignore the nightly tag when to generate the changelog, which was a wasted effort 🤣 . |
- nightly: run on schedule at UTC 16:00 (GMT+8 0:00) everyday - nightly: remove existing artifacts - nightly: only build on the main repo and the default branch - release & nightly: ignore prerelease when generate the changelog - release & nightly: always fetch submodule
924a14a
to
d3ce143
Compare
Pull request
Issue tracker
Fixes will automatically close the related issues
Fixes # N/A
Feature
Describe features of pull request
Code of conduct
Style lint
make sytle-lint
Build pass
make debug
Manually test
Code Review
Daily build
Login and download artifact at https://github.com/osfans/trime/actions
Additional Info