Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: directly read theme name instead of caching using local var… #1182

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

goofyz
Copy link
Collaborator

@goofyz goofyz commented Jan 17, 2024

Pull request

Issue tracker

Fixes will automatically close the related issues

Fixes #1168

Feature

Describe features of pull request

Code of conduct

Style lint

  • make sytle-lint

Build pass

  • make debug

Manually test

  • Done

Code Review

  1. No wildcards import
  2. Manual build and test pass
  3. GitHub action ci pass
  4. At least one contributor reviews and votes
  5. Can be merged clean without conflicts
  6. PR will be merged by rebase upstream base

Daily build

Login and download artifact at https://github.com/osfans/trime/actions

Additional Info

@goofyz goofyz self-assigned this Jan 17, 2024
@goofyz goofyz merged commit af709fe into osfans:develop Jan 17, 2024
3 checks passed
@goofyz goofyz deleted the fix-1168 branch January 17, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

闪退
1 participant