Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the crash that happens when the screen is rotated. #1054

Merged
merged 1 commit into from
Jul 30, 2023

Conversation

shitlime
Copy link
Contributor

#1014

Pull request

Issue tracker

Fixes will automatically close the related issues

Fixes #
Fix the crash that happens when the screen is rotated.
#1014

在旋转屏幕时,Android系统检测到 toolbar 的id重复导致的崩溃。

在主设置界面和日志界面中存在相同的的id toolbar

Feature

Describe features of pull request

Code of conduct

Style lint

  • make sytle-lint

Build pass

  • make debug

Manually test

  • Done

Code Review

  1. No wildcards import
  2. Manual build and test pass
  3. GitHub action ci pass
  4. At least one contributor reviews and votes
  5. Can be merged clean without conflicts
  6. PR will be merged by rebase upstream base

Daily build

Login and download artifact at https://github.com/osfans/trime/actions

Additional Info

@Bambooin
Copy link
Collaborator

Thanks for your kind attribution and help.

Two tips for GitHub:

  1. Use the pull request template with fix 主界面旋屏崩溃/home screen rotate crashed. #1014, and this will close the issue automatically.

  2. We shoud use all lower case in git message in [CONTRIBUTING.md]

@Bambooin Bambooin merged commit 59ba807 into osfans:develop Jul 30, 2023
1 check passed
@shitlime
Copy link
Contributor Author

Thanks for your kind attribution and help.

Two tips for GitHub:

1. Use the pull request template with fix [主界面旋屏崩溃/home screen rotate crashed. #1014](https://github.com/osfans/trime/issues/1014), and this will close the issue automatically.

2. We shoud use all lower case in git message in [CONTRIBUTING.md]

感谢提醒,下次会注意

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants