-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add prune_with_map_projection #751
Conversation
@RafaelDavidMohr Could you please have a look if these changes include the information you need? |
Co-authored-by: Max Horn <[email protected]>
src/module/module.jl
Outdated
Returns the module R minimally embedded in a free module such that the | ||
corresponding factor modules are isomorphic, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand this docstring: There is one argument id
; it is not stated how it related to R
. And then the next line, is that transformation matrix meant to be another return value?
How about this (assuming I guessed the meaning right, which I probably didn't):
Returns the module R minimally embedded in a free module such that the | |
corresponding factor modules are isomorphic, | |
Return a module `R`, a transformation matrix `M` and a projection map `p` | |
satisfying the following properties: `R` is minimally embedded in a free | |
module `parent(R)` such that the quotient `parent(R)/R` is isomorphic to `id`, | |
with `M` describing this isomorphism, and `p` mapping `gen(id, i)` to | |
`gen(id, p(i))` |
I am still rather confused by the usage of gen(i)
(what is i
? An index ranging over 1 .. ngens(id)
maybe?!?), and why p[i]
-- is p
a vector, or a function, or what?
If @fingolfin's documentation update above is correct, then yes, this is what I need. Essentially I just need the map |
@ederc