-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge libsingular-julia back into Singular.jl #657
Merged
fingolfin
merged 122 commits into
oscar-system:master
from
fingolfin:mh/merge-libsingular
Jun 7, 2023
Merged
Merge libsingular-julia back into Singular.jl #657
fingolfin
merged 122 commits into
oscar-system:master
from
fingolfin:mh/merge-libsingular
Jun 7, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add id_LiftStd * fix: id_LiftStd Co-authored-by: thofma <[email protected]>
* "fix" CmakeFile and add a build.jl which is not perfect (I don;t know what the conventions are) but it illustrates what to do * Update build.jl Co-authored-by: thofma <[email protected]>
- version with/out syzygies - add complete_reduction
... it is identical to n_Delete
... by letting it return its result, instead of void.
…r-system#10) * First try on conversion of Singular.jl arrays to Singular lists Added a first try on conversion of Singular.jl arrays to Singular lists in order to be able to call more Singular libraries in Singular.jl * Fixed type. Changed name of function.
* getting and setting the minpoly * fix minpoly functions
To use this, you can start it inside the `libsingular-julia` directory via julia --project=. run.jl and it will first install a few Julia packages, then build all C++ code, and finally start a Julia session with an artifact override in place which ensures that `libsingular_julia_jll` picks up the copy of the C++ code that was just compiled. To verify the override is in effect, check the value of `libsingular_julia_jll.artifact_dir`. You can now e.g. `Pkg.add("Singular")` and then `Pkg.test("Singular")`; or do `using Singular` to test Singular interactively.
put all julia 1.6 tests to includes to avoid weird matrix-includes mixup
gc protection
add homogeneous functions
Don't corrupt the ring data. Also, incidentally use lex.
add getter for qideal
add functions for std_hilbert
reset some global error flags
access to mp_Wedge
add id_MinStd
add id_DivRem, id_DivRem_Unit
Hs/sc hilb weighted
add nres/mres: id_res
benlorenz
approved these changes
Jun 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the history back in, blame
and log
look reasonable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This imports the history from https://github.com/oscar-system/libsingular-julia into this repository, in preparation for PR #639.
I tried to stich back the history in such a way that "git blame" and similar work seamlessly.