-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Groebner Walk #571
base: master
Are you sure you want to change the base?
feat: Groebner Walk #571
Conversation
…nto groebnerwalk
Pertubed_walk- prototype works fine
…nto groebnerwalk
feat: Struct MonomialOrder
feat: new nextW - method for pertubed Walks Solved: Bug in tdeg()
fix: delete not needed integration.
fix: Tippfehler
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi there,
thanks for your contribution. (Out of curiosity: who are you? Are you a member of the SFB-TRR 195 or outsider?)
I am afraid this PR will need some major revisions. E.g. just on the surface level: test related files should be in test/GroebnerWalk
; runtests
is missing a file extension; there are typos in filenames ("Utilitys" -> "Utilities"). But then also inside there are a structural issues.
Perhaps it'd be best to discuss this via a video chat instead of lengthy comments here.
I would also suggest that Singular.jl is not necessarily the place such a large feature as this. Singular.jl is mainly for an interface to singular, and features like this belong in other packages. But, I am open to having my mind changed on this point. |
I just talked to @ederc on the phone who explained the background of this PR: @welpj is a master student of him and Anne. This PR will be revised. And he also said that perhaps it should rather go into Oscar.jl. So, we can just leave this PR aside for the moment, until Anne and Christian tell us it is ready (resp. move it to Oscar.jl) |
fix: typos
Implementation of the Gröbner Walk.
This branch contributes the following algorithms: