Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add prune_with_map_projection #751

Merged
merged 5 commits into from
Jan 23, 2024

Conversation

hannes14
Copy link
Member

@ederc
Copy link
Member

ederc commented Jan 22, 2024

@RafaelDavidMohr Could you please have a look if these changes include the information you need?

src/module/module.jl Outdated Show resolved Hide resolved
Comment on lines 414 to 415
Returns the module R minimally embedded in a free module such that the
corresponding factor modules are isomorphic,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand this docstring: There is one argument id; it is not stated how it related to R. And then the next line, is that transformation matrix meant to be another return value?

How about this (assuming I guessed the meaning right, which I probably didn't):

Suggested change
Returns the module R minimally embedded in a free module such that the
corresponding factor modules are isomorphic,
Return a module `R`, a transformation matrix `M` and a projection map `p`
satisfying the following properties: `R` is minimally embedded in a free
module `parent(R)` such that the quotient `parent(R)/R` is isomorphic to `id`,
with `M` describing this isomorphism, and `p` mapping `gen(id, i)` to
`gen(id, p(i))`

I am still rather confused by the usage of gen(i) (what is i? An index ranging over 1 .. ngens(id) maybe?!?), and why p[i] -- is p a vector, or a function, or what?

@RafaelDavidMohr
Copy link

If @fingolfin's documentation update above is correct, then yes, this is what I need. Essentially I just need the map parent(R)/R -> id

src/module/module.jl Outdated Show resolved Hide resolved
@hannes14 hannes14 merged commit f57e226 into oscar-system:master Jan 23, 2024
13 of 14 checks passed
@hannes14 hannes14 deleted the hs/libsingular_prune branch January 23, 2024 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants