Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix _as_subgroups #4277

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Conversation

ThomasBreuer
Copy link
Member

and extend tests accordingly,
and fix == for group homomorphisms

resolves #4276

and extend tests accordingly,
and fix `==` for group homomorphisms
Copy link
Member

@joschmitt joschmitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

The failing book test seems to be vinberg2.jlcon again, I restarted.

@joschmitt joschmitt enabled auto-merge (squash) November 6, 2024 12:01
@joschmitt joschmitt merged commit 8bea0b6 into oscar-system:master Nov 6, 2024
26 checks passed
Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.49%. Comparing base (50d2662) to head (21c4ab2).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4277      +/-   ##
==========================================
- Coverage   84.50%   84.49%   -0.01%     
==========================================
  Files         641      641              
  Lines       85473    85467       -6     
==========================================
- Hits        72225    72217       -8     
- Misses      13248    13250       +2     
Files with missing lines Coverage Δ
src/Groups/homomorphisms.jl 91.17% <100.00%> (ø)
src/Groups/sub.jl 95.65% <100.00%> (-0.14%) ⬇️

... and 1 file with indirect coverage changes

@ThomasBreuer ThomasBreuer deleted the TB_as_subgroups branch November 6, 2024 13:14
@fingolfin fingolfin mentioned this pull request Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

normal_subgroups for FPGroup broken?
3 participants