make the GapObj in left/right cosets optional
#4274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compute the GAP coset object only if one asks for it. In particular, do not use it for comparing left cosets with `==`.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4274 +/- ##
==========================================
+ Coverage 84.48% 84.50% +0.01%
==========================================
Files 641 641
Lines 85447 85488 +41
==========================================
+ Hits 72189 72238 +49
+ Misses 13258 13250 -8
|
fingolfin
approved these changes
Nov 7, 2024
src/Groups/cosets.jl
Outdated
Comment on lines
37
to
43
| (x.side == y.side && x.G == y.G && x.H == y.H ) || return false | ||
| if is_right(x) | ||
| # Hx == Hy if x/y in H | ||
| return representative(x) / representative(y) in x.H | ||
| else | ||
| # xH == yH if x\y in H | ||
| return representative(x) \ representative(y) in x.H |
There was a problem hiding this comment.
I find the comment versus object names confusing: x; where the x.H and the representative(x).
Perhaps we can name things a bit and e.g. call the Julia variables differently (say A and B), or the comment variables (e.g. Ha and Hb)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compute the GAP coset object only if one asks for it. In particular, do not use it for comparing left cosets with
==.The implementation is the same as for double cosets, cf. #3899.
This addresses the discussion in #118.