Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add stabilizer for G-sets w.r.t. derived actions #4265

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

ThomasBreuer
Copy link
Member

The stabilizer of a Set of points in the G-set is the setwise stabilizer. The stabilizer of a Vector or Tuple of points in the G-set is the pointwise stabilizer.

The stabilizer of a `Set` of points in the G-set is the setwise stabilizer.
The stabilizer of a `Vector` or `Tuple` of points in the G-set is the pointwise stabilizer.
Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.48%. Comparing base (4ab6f4d) to head (942e0af).
Report is 12 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4265      +/-   ##
==========================================
- Coverage   84.60%   84.48%   -0.12%     
==========================================
  Files         640      641       +1     
  Lines       85117    85445     +328     
==========================================
+ Hits        72011    72186     +175     
- Misses      13106    13259     +153     
Files with missing lines Coverage Δ
src/Groups/gsets.jl 92.15% <100.00%> (+0.51%) ⬆️

... and 17 files with indirect coverage changes

src/Groups/gsets.jl Outdated Show resolved Hide resolved
src/Groups/gsets.jl Outdated Show resolved Hide resolved
src/Groups/gsets.jl Outdated Show resolved Hide resolved
src/Groups/gsets.jl Outdated Show resolved Hide resolved
src/Groups/gsets.jl Outdated Show resolved Hide resolved
src/Groups/gsets.jl Outdated Show resolved Hide resolved
Copy link
Collaborator

@mjrodgers mjrodgers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is good as a first implementation, and all of the remarks of @lgoettgens seem to be addressed.

I think as a next step maybe we can implement these without computing the entire group action on sets/tuples; but I think we should merge this now and then I will open a separate issue for performance improvements.

@joschmitt joschmitt merged commit 19bf27c into oscar-system:master Nov 5, 2024
29 checks passed
@ThomasBreuer ThomasBreuer deleted the TB_set_stabilizer branch November 5, 2024 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants