-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add stabilizer
for G-sets w.r.t. derived actions
#4265
Conversation
The stabilizer of a `Set` of points in the G-set is the setwise stabilizer. The stabilizer of a `Vector` or `Tuple` of points in the G-set is the pointwise stabilizer.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4265 +/- ##
==========================================
- Coverage 84.60% 84.48% -0.12%
==========================================
Files 640 641 +1
Lines 85117 85445 +328
==========================================
+ Hits 72011 72186 +175
- Misses 13106 13259 +153
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is good as a first implementation, and all of the remarks of @lgoettgens seem to be addressed.
I think as a next step maybe we can implement these without computing the entire group action on sets/tuples; but I think we should merge this now and then I will open a separate issue for performance improvements.
The stabilizer of a
Set
of points in the G-set is the setwise stabilizer. The stabilizer of aVector
orTuple
of points in the G-set is the pointwise stabilizer.