Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QuadFormAndIsom: add a missing check and remove some unnecessary @req #4262

Merged
merged 2 commits into from
Nov 1, 2024

fix obvious broken test

5f77a8f
Select commit
Loading
Failed to load commit list.
Merged

QuadFormAndIsom: add a missing check and remove some unnecessary @req #4262

fix obvious broken test
5f77a8f
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 31, 2024 in 1s

84.60% (+0.00%) compared to 4ab6f4d

View this Pull Request on Codecov

84.60% (+0.00%) compared to 4ab6f4d

Details

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.60%. Comparing base (4ab6f4d) to head (5f77a8f).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4262   +/-   ##
=======================================
  Coverage   84.60%   84.60%           
=======================================
  Files         640      640           
  Lines       85117    85118    +1     
=======================================
+ Hits        72009    72010    +1     
  Misses      13108    13108           
Files with missing lines Coverage Δ
experimental/QuadFormAndIsom/src/embeddings.jl 96.62% <100.00%> (ø)
experimental/QuadFormAndIsom/src/enumeration.jl 93.68% <100.00%> (+0.01%) ⬆️
experimental/QuadFormAndIsom/test/runtests.jl 100.00% <ø> (ø)