Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intersect. theory: Further clean up #4188

Merged
merged 2 commits into from
Oct 9, 2024
Merged

Intersect. theory: Further clean up #4188

merged 2 commits into from
Oct 9, 2024

Conversation

wdecker
Copy link
Collaborator

@wdecker wdecker commented Oct 9, 2024

No description provided.

@wdecker
Copy link
Collaborator Author

wdecker commented Oct 9, 2024

@benlorenz Can you please check what is happening here:

Run tests / test (1.6, short, ubuntu-latest) (pull_request)

@benlorenz
Copy link
Member

@benlorenz Can you please check what is happening here:

Run tests / test (1.6, short, ubuntu-latest) (pull_request)

This seems to happen on master as well, my guess is that github changed the gcc version to something that is newer than the bundled libstdc++ for julia 1.6. See #4189

@benlorenz benlorenz closed this Oct 9, 2024
@benlorenz benlorenz reopened this Oct 9, 2024
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.59%. Comparing base (7769ffa) to head (0aaeed0).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4188   +/-   ##
=======================================
  Coverage   84.58%   84.59%           
=======================================
  Files         631      631           
  Lines       84829    84831    +2     
=======================================
+ Hits        71754    71759    +5     
+ Misses      13075    13072    -3     
Files with missing lines Coverage Δ
...xperimental/ExteriorAlgebra/src/ExteriorAlgebra.jl 100.00% <ø> (ø)
experimental/IntersectionTheory/src/Main.jl 92.90% <ø> (ø)
experimental/IntersectionTheory/src/blowup.jl 99.24% <100.00%> (+0.77%) ⬆️

... and 1 file with indirect coverage changes

@thofma thofma enabled auto-merge (squash) October 9, 2024 21:32
@thofma thofma merged commit c146706 into master Oct 9, 2024
55 of 57 checks passed
@thofma thofma deleted the Wolfram branch October 9, 2024 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants