Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two neighbor step in char 0 #4183

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
1c46091
Repair methods for has_dim_leq_zero.
HechtiDerLachs Oct 4, 2024
9684758
WIP to reduce to pos. char.
HechtiDerLachs Oct 7, 2024
bc918bc
Make two_neighbor_step work in char. 0.
HechtiDerLachs Oct 7, 2024
af1e9c8
Remove debug comments.
HechtiDerLachs Oct 7, 2024
a1c1f28
Take care of non-principal exceptional divisors.
HechtiDerLachs Oct 8, 2024
ff04310
Clean up reduction to positive characteristic.
HechtiDerLachs Oct 8, 2024
611adfc
Introduce a type of its own for sections and use it.
HechtiDerLachs Oct 8, 2024
929ddac
Use AbsWeilDivisor consistently.
HechtiDerLachs Oct 8, 2024
1e85bd3
More AbsWeilDivisor.
HechtiDerLachs Oct 8, 2024
bf57e5e
Merge branch 'master' into two_neighbor_step_in_char_0
simonbrandhorst Oct 10, 2024
c25dddb
wip
simonbrandhorst Oct 28, 2024
67a8d04
Merge branch 'master' into two_neighbor_step_in_char_0
simonbrandhorst Oct 30, 2024
f42e314
enable computation of admissible transformations on the weierstrass c…
simonbrandhorst Oct 30, 2024
8ffb020
Extend _cmp_res and add assertion to mappings.
HechtiDerLachs Oct 15, 2024
0c348eb
good_reduction -> raw_good_reduction.
HechtiDerLachs Oct 30, 2024
5e89ad1
Speed up mappings from quotient rings.
HechtiDerLachs Oct 30, 2024
d06d999
Implement various reduction methods to pos. char..
HechtiDerLachs Oct 30, 2024
7abad54
Turn primeness-check into an hassert.
HechtiDerLachs Oct 30, 2024
122cdf6
Add reduction method for automorphisms.
HechtiDerLachs Oct 30, 2024
4e942fe
Add some assertions and vprints.
HechtiDerLachs Oct 31, 2024
3642189
Allow more sources for self intersection.
HechtiDerLachs Oct 31, 2024
ba3dece
Add some more assertions.
HechtiDerLachs Oct 31, 2024
cc03158
Disable caching for cheap_realizations for the moment.
HechtiDerLachs Oct 31, 2024
52b58ba
one more AbsWeilDivisor
simonbrandhorst Nov 1, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions experimental/Schemes/src/BlowupMorphism.jl
Original file line number Diff line number Diff line change
Expand Up @@ -644,18 +644,18 @@
f_loc = covering_morphism(f)[U]
V = codomain(f_loc)
IE_loc = IE(U)
@assert isone(ngens(IE_loc)) "ideal sheaf of exceptional locus is not principal"
tot = pullback(f_loc)(J(V))
#return saturation_with_index(tot, IE_loc)
# It is usually better to pass to the simplified covering to do the computations
simp_cov = simplified_covering(X)
U_simp = first([V for V in patches(simp_cov) if original(V) === U])
a, b = identification_maps(U_simp)
# This used to be the following line. But we don't use the index, so we
# switch to the more performant version
# result, _ = saturation_with_index(pullback(a)(tot), pullback(a)(IE_loc))
result = _iterative_saturation(pullback(a)(tot), elem_type(OO(U_simp))[pullback(a)(u) for (u, _) in factor(lifted_numerator(first(gens(IE_loc))))])
return pullback(b)(result)
tot = pullback(f_loc)(J(V))
if isone(ngens(IE_loc))
result = _iterative_saturation(pullback(a)(tot), elem_type(OO(U_simp))[pullback(a)(u) for (u, _) in factor(lifted_numerator(first(gens(IE_loc))))])
return pullback(b)(result)
else
result, _ = saturation_with_index(pullback(a)(tot), pullback(a)(IE_loc))
return result

Check warning on line 657 in experimental/Schemes/src/BlowupMorphism.jl

View check run for this annotation

Codecov / codecov/patch

experimental/Schemes/src/BlowupMorphism.jl#L656-L657

Added lines #L656 - L657 were not covered by tests
end
end

@attr Bool function is_prime(I::StrictTransformIdealSheaf)
Expand Down
Loading
Loading