Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FTheoryTools] Fixed some bugs that were missed before #4182

Merged
merged 1 commit into from
Oct 11, 2024

Fixed some bugs that were missed before

96b0331
Select commit
Loading
Failed to load commit list.
Merged

[FTheoryTools] Fixed some bugs that were missed before #4182

Fixed some bugs that were missed before
96b0331
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 11, 2024 in 0s

84.65% (+0.06%) compared to 759becf

View this Pull Request on Codecov

84.65% (+0.06%) compared to 759becf

Details

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 84.65%. Comparing base (759becf) to head (96b0331).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
.../FTheoryTools/src/LiteratureModels/create_index.jl 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4182      +/-   ##
==========================================
+ Coverage   84.58%   84.65%   +0.06%     
==========================================
  Files         631      631              
  Lines       84829    85271     +442     
==========================================
+ Hits        71756    72184     +428     
- Misses      13073    13087      +14     
Files with missing lines Coverage Δ
.../FTheoryTools/src/AbstractFTheoryModels/methods.jl 78.27% <ø> (ø)
.../FTheoryTools/src/LiteratureModels/constructors.jl 93.85% <100.00%> (+0.04%) ⬆️
...rimental/FTheoryTools/src/TateModels/attributes.jl 86.58% <ø> (ø)
...l/FTheoryTools/src/WeierstrassModels/attributes.jl 86.53% <ø> (ø)
.../FTheoryTools/src/LiteratureModels/create_index.jl 0.00% <0.00%> (ø)

... and 5 files with indirect coverage changes