booktests: some future-proofing #4172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lkastner
approved these changes
Oct 2, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4172 +/- ##
==========================================
- Coverage 84.69% 84.69% -0.01%
==========================================
Files 628 628
Lines 84578 84578
==========================================
- Hits 71636 71634 -2
- Misses 12942 12944 +2 |
benlorenz
added a commit
that referenced
this pull request
Oct 15, 2024
(cherry picked from commit ec05d52)
benlorenz
added a commit
that referenced
this pull request
Oct 18, 2024
(cherry picked from commit ec05d52)
benlorenz
added a commit
that referenced
this pull request
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
run booktests with nightly as well