fix too restrictive method installations #4149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In many situations, we cannot expect that compatible groups have the same type.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4149 +/- ##
==========================================
+ Coverage 84.65% 84.69% +0.04%
==========================================
Files 626 627 +1
Lines 84316 84300 -16
==========================================
+ Hits 71380 71401 +21
+ Misses 12936 12899 -37
|
fingolfin
reviewed
Sep 24, 2024
- adjust reference in .md file - change more types in signatures - extend tests - fix `small_group` with given type: apply it to an Oscar group not a GAP group - fix `sub`: the type check was wrong, and the compatibility is checked anyhow
lgoettgens
reviewed
Sep 25, 2024
lgoettgens
reviewed
Sep 25, 2024
lgoettgens
approved these changes
Sep 26, 2024
src/Groups/homomorphisms.jl
Outdated
| @@ -1298,7 +1297,7 @@ end | |||
| Base.:^(x::GAPGroupElem{T},f::GAPGroupElem{AutomorphismGroup{T}}) where T <: GAPGroup = apply_automorphism(f, x, true) | |||
| #Base.:^(f::GAPGroupElem{AutomorphismGroup{T}},g::GAPGroupElem{AutomorphismGroup{T}}) where T <: GAPGroup = g^-1*f*g | |||
|
|
|||
| function (A::AutomorphismGroup{T})(f::GAPGroupHomomorphism{T,T}) where T <: GAPGroup | |||
| function (A::AutomorphismGroup{S})(f::GAPGroupHomomorphism{T,T}) where S <: GAPGroup where T <: GAPGroup | |||
There was a problem hiding this comment.
Suggested change
| function (A::AutomorphismGroup{S})(f::GAPGroupHomomorphism{T,T}) where S <: GAPGroup where T <: GAPGroup | |
| function (A::AutomorphismGroup{S})(f::GAPGroupHomomorphism{T,T}) where {S <: GAPGroup, T <: GAPGroup} |
a double where is almost never necessary.
Alternatively, you could even do
Suggested change
| function (A::AutomorphismGroup{S})(f::GAPGroupHomomorphism{T,T}) where S <: GAPGroup where T <: GAPGroup | |
| function (A::AutomorphismGroup{<: GAPGroup})(f::GAPGroupHomomorphism{T,T}) where T <: GAPGroup |
There was a problem hiding this comment.
o.k.
Concerning the multiple where, there are lots in many code files, this is perhaps something for a pull request of its own.
HechtiDerLachs
pushed a commit
to HechtiDerLachs/Oscar.jl
that referenced
this pull request
Sep 30, 2024
In many situations, we cannot expect that compatible groups have the same type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In many situations,
we cannot expect that compatible groups have the same type.
resolves #4144