LieAlgebras: more optimizations regarding type stability #4145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lgoettgens
added
topic: LieAlgebras
experimental
lgoettgens
force-pushed
the
lg/Lie-optim
branch
2 times, most recently
from
90cbfa3
to
01ddde4
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4145 +/- ##
=======================================
Coverage 84.65% 84.66%
=======================================
Files 626 626
Lines 84316 84320 +4
=======================================
+ Hits 71380 71386 +6
+ Misses 12936 12934 -2
|
fingolfin
approved these changes
Sep 26, 2024
Comment on lines
+7
to
+11
| if !isdefined(Main, :mrdi_schema) | ||
| mrdi_schema = Schema(JSON.parsefile(joinpath(Oscar.oscardir, "data", "schema.json"))) | ||
| end | ||
|
|
||
| if !isdefined(Main, :test_save_load_roundtrip) || isinteractive() |
There was a problem hiding this comment.
This seems to be an unrelated change?
There was a problem hiding this comment.
Yeah, this should have been included in #4065, but I forgot it somehow.
Without this change, running Oscar.test_experimental_module("LieAlgebras") from the REPL parses the schema multiple times, including some network request and some logging.
HechtiDerLachs
pushed a commit
to HechtiDerLachs/Oscar.jl
that referenced
this pull request
Sep 30, 2024
…m#4145) * Add second type param to `LieAlgebraModule` * Make more tests `@inferred` * Reduce test output spam * Another type annotation fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.