Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable anonymous functions in gluings #4111

Conversation

HechtiDerLachs
Copy link
Collaborator

@HechtiDerLachs HechtiDerLachs commented Sep 18, 2024

This is some independent work carried out on #4110 .

It removes the anonymous functions inside the LazyGluings. These are not necessary and they don't serialize nicely. So I took them out.

In the course of this I disabled the possibility to "cheaply" compute only the gluing domains. This turned out not to be useful and it just made things more complicated.

@HechtiDerLachs
Copy link
Collaborator Author

Tests seem to pass, but the booktests. But that looks rather like a hickup, doesn't it?

Copy link

codecov bot commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 63.33333% with 11 lines in your changes missing coverage. Please review.

Project coverage is 84.65%. Comparing base (9575e9a) to head (e4a7628).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
...metry/Schemes/PrincipalOpenSubset/Objects/Types.jl 0.00% 10 Missing ⚠️
...braicGeometry/Schemes/Gluing/LazyGluing/Methods.jl 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4111      +/-   ##
==========================================
- Coverage   84.67%   84.65%   -0.02%     
==========================================
  Files         626      626              
  Lines       83980    83983       +3     
==========================================
- Hits        71108    71100       -8     
- Misses      12872    12883      +11     
Files with missing lines Coverage Δ
experimental/Schemes/src/Auxiliary.jl 94.20% <100.00%> (ø)
...perimental/Schemes/src/CoveredProjectiveSchemes.jl 88.30% <100.00%> (ø)
...y/Schemes/CoveredSchemes/Morphisms/Constructors.jl 95.45% <100.00%> (ø)
...Geometry/Schemes/CoveredSchemes/Objects/Methods.jl 94.70% <100.00%> (ø)
...raicGeometry/Schemes/Covering/Morphisms/Methods.jl 98.64% <100.00%> (ø)
...ebraicGeometry/Schemes/Covering/Objects/Methods.jl 81.19% <100.00%> (+0.08%) ⬆️
...gebraicGeometry/Schemes/Gluing/LazyGluing/Types.jl 100.00% <100.00%> (ø)
src/AlgebraicGeometry/Schemes/Gluing/Methods.jl 95.52% <100.00%> (ø)
.../AlgebraicGeometry/Schemes/Sheaves/IdealSheaves.jl 80.49% <100.00%> (ø)
...Geometry/ToricVarieties/ToricSchemes/attributes.jl 67.39% <100.00%> (ø)
... and 2 more

... and 1 file with indirect coverage changes

@joschmitt joschmitt merged commit b5d0b43 into oscar-system:master Sep 19, 2024
28 checks passed
Copy link
Collaborator

@afkafkafk13 afkafkafk13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Makes sense and does the job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants