switch to a better Julia to GAP conversion #4086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThomasBreuer
force-pushed
the
TB_julia_to_gap
branch
from
6fb0353
to
8378833
Compare
|
@ThomasBreuer this has conflicts now? |
- install `GapObj` and `GAP.julia_to_gap` methods via `GAP.@install` - change the `GAP.julia_to_gap` calls to `GapObj` calls - move some conversion methods from Oscar.jl to GAP.jl
ThomasBreuer
force-pushed
the
TB_julia_to_gap
branch
from
3e037fe
to
f9e4450
Compare
|
With the new Hecke release available, CI seems to be happy now |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4086 +/- ##
==========================================
- Coverage 84.69% 84.69% -0.01%
==========================================
Files 627 627
Lines 84301 84287 -14
==========================================
- Hits 71398 71385 -13
+ Misses 12903 12902 -1
|
fingolfin
approved these changes
Sep 27, 2024
There was a problem hiding this comment.
Looks good to me. It would be good if GAP.jl still provided julia_to_gap as fallback for existing code. I.e. we don't want people to install methods it, but code that just calls it should keep working. So something like julia_to_gap(x) = GapObj in GAP.jl might work (perhaps recursive also needs to be passed on)
HechtiDerLachs
pushed a commit
to HechtiDerLachs/Oscar.jl
that referenced
this pull request
Sep 30, 2024
* next iteration
- install `GapObj` and `GAP.julia_to_gap` methods via `GAP.@install`
- change the `GAP.julia_to_gap` calls to `GapObj` calls
- move some conversion methods from Oscar.jl to GAP.jl
* do not call `GapObj(Union{}[])`
* require GAP.jl 0.12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes rely on those in GAP.jl from oscar-system/GAP.jl/pull/1029, see the introductory comment there for the ideas.
The details are as follows.
GapObjandGAP.julia_to_gapmethods to calls ofGAP.@install GapObjGAP.julia_to_gapcalls toGapObjcallsSet{T}andJSON3.Arrayto GAP.jlAs soon as Oscar.jl includes GAP.jl containing the code from oscar-system/GAP.jl/pull/1029, the current changes (or something better) must be added to Oscar.jl.