Avoid bottlenecks in variable matching (#4178)

oscar-system · Oct 7, 2024 · 9cda843 · 9cda843
1 parent c8a64e6
commit 9cda843
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/src/Rings/MPolyMap/Types.jl b/src/Rings/MPolyMap/Types.jl
@@ -35,12 +35,15 @@ const _DomainTypes = Union{MPolyRing, MPolyQuoRing}
     # can safely be disabled.
     if check_for_mapping_of_vars && all(_is_gen, img_gens) && _allunique(img_gens)
       gens_codomain = gens(codomain)
-      result.variable_indices = [findfirst(==(x), gens_codomain) for x in img_gens]
+      result.variable_indices = [findfirst(_cmp_reps(x), gens_codomain) for x in img_gens]
     end
     return result
   end
 end
 
+# This can be overwritten in order to avoid making the above check a bottleneck.
+_cmp_reps(a) = ==(a)
+
 function MPolyAnyMap(d::D, c::C, cm::U, ig::Vector{V}) where {D, C, U, V}
   return MPolyAnyMap{D, C, U, V}(d, c, cm, ig)
 end

diff --git a/src/Rings/mpolyquo-localizations.jl b/src/Rings/mpolyquo-localizations.jl
@@ -2804,3 +2804,7 @@ _exponents(x::MPolyQuoRingElem) = AbstractAlgebra.exponent_vectors(lift(x))
 _exponents(x::MPolyLocRingElem) = AbstractAlgebra.exponent_vectors(numerator(x))
 _exponents(x::MPolyQuoLocRingElem) = AbstractAlgebra.exponent_vectors(lifted_numerator(x))
 
+# overwriting the comparison method to avoid computing saturations and groebner bases.
+_cmp_reps(a::MPolyLocRingElem) = y->(fraction(y) == fraction(a))
+_cmp_reps(a::MPolyQuoLocRingElem) = y->(fraction(y) == fraction(a))
+