Add FORCE_JULIAINTERFACE_COMPILATION
#999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #999 +/- ##
=======================================
Coverage 75.75% 75.75%
=======================================
Files 51 51
Lines 4190 4190
=======================================
Hits 3174 3174
Misses 1016 1016
|
fingolfin
approved these changes
May 27, 2024
| @@ -232,12 +232,12 @@ function locate_JuliaInterface_so(sysinfo::Dict{String, String}) | |||
| jll_hash = GitTools.tree_hash(joinpath(jll, "src")) | |||
| bundled = joinpath(@__DIR__, "..", "pkg", "JuliaInterface") | |||
| bundled_hash = GitTools.tree_hash(joinpath(bundled, "src")) | |||
| if jll_hash == bundled_hash | |||
| if jll_hash == bundled_hash && get(ENV, "FORCE_JULIAINTERFACE_COMPILATION", "false") != "true" | |||
There was a problem hiding this comment.
Usually I'd just check for the presence of such a variable and not care about the content. But since this is not intended for user consumption, I am fine either way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #997.
I verified by looking at debug output that just running the GAP.jl master uses the jll-version while running
julia --proj=override etc/run_with_override.jl /tmp/gap_jll_override --depwarn=error -e "ENV[\"JULIA_DEBUG\"] = all; using GAP"prints[Info: Compiling JuliaInterface...