change iteration over GAP objects #1057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ThomasBreuer
commented
Oct 18, 2024
ThomasBreuer
commented
- omit holes when iterating over GAP lists (resolves Skip holes when iterating over GAP lists? #970)
- extend documentation accordingly
- fix a GAPDoc error in the JuliaInterface manual
- omit holes when iterating over GAP lists - extend documentation - fix a GAPDoc error in the JuliaInterface manual
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1057 +/- ##
==========================================
- Coverage 74.98% 74.92% -0.07%
==========================================
Files 55 55
Lines 4549 4554 +5
==========================================
+ Hits 3411 3412 +1
- Misses 1138 1142 +4
|
The effect of this missing declaration was strange:
I did not get error messages when trying `include("test/runtests.jl")`,
but the CI tests showed the GAP warning
together with an (intended) error message,
which caused a different output there and hence a test failure.
lgoettgens
reviewed
Oct 18, 2024
| @@ -496,7 +495,12 @@ end | |||
|
|
|||
| function Base.iterate(obj::GapObj, (i, len)::Tuple{Int,Int}) | |||
| i > len && return nothing | |||
| ElmList(obj, i), (i+1, len) | |||
| res = ElmList(obj, i) | |||
| while res === nothing # dangerous if `len` is *larger* than the length | |||
There was a problem hiding this comment.
is it possible for a GAP iterator to have holes at the end? If yes, this may be an infinite loop.
There was a problem hiding this comment.
The length is the position of the last bound element. Thus it is safe to call the function with the correct len.
However, if one deliberately enters a too big len and i is not larger than len but already larger than the length then one enters the while loop, and this loop will be infinite.
fingolfin
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.