Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hack to avoid warning about Downloads package #1054

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

fingolfin
Copy link
Member

The "proper" fix will come eventually with the new packagemanager. But in the meantime this should fix #1040 for users.

Copy link

codecov bot commented Sep 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.83%. Comparing base (e5c5358) to head (560d6c0).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1054   +/-   ##
=======================================
  Coverage   75.83%   75.83%           
=======================================
  Files          55       55           
  Lines        4543     4544    +1     
=======================================
+ Hits         3445     3446    +1     
  Misses       1098     1098           
Files with missing lines Coverage Δ
pkg/JuliaInterface/gap/JuliaInterface.gi 91.95% <100.00%> (+0.09%) ⬆️

Copy link
Member

@ThomasBreuer ThomasBreuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.
The warning disappears, nothing else changes.

@fingolfin fingolfin merged commit 507270e into oscar-system:master Sep 24, 2024
21 checks passed
@fingolfin fingolfin deleted the mh/Downloads-warning-hack branch September 24, 2024 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warning "The Julia package 'Downloads' cannot be loaded" when starting GAP.jl in CI
2 participants