fix access to Julia docstrings from the GAP session #1034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- call `Julia.GAP.UnwrapJuliaFunc` on the argument of `Julia.GAP.julia_help_string` - make `HelpString` work for Julia functions such that the fix can be tested easily - add tests
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1034 +/- ##
==========================================
+ Coverage 75.97% 76.49% +0.51%
==========================================
Files 51 51
Lines 4184 4191 +7
==========================================
+ Hits 3179 3206 +27
+ Misses 1005 985 -20
|
fingolfin
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Julia.GAP.UnwrapJuliaFuncon the argument ofJulia.GAP.julia_help_stringHelpStringwork for Julia functions such that the fix can be tested easily(I noticed the problem in the context of renaming
julia_to_gapfor #1029, but the fix is independent from that pull request.)