fix a test #1028
Merged
fix a test #1028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tests ``` @test GAP.Packages.install("fga", interactive = false) @test ! isempty(GAP.Packages.locate_package("fga")) ``` pass only if the FGA package was already loaded before the tests, which is the case in usual installations. If one starts GAP without packages (`-A` option) then the second test fails. One has to load the package in order to be sure that `locate_package` returns a nonempty result.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1028 +/- ##
==========================================
+ Coverage 76.73% 76.82% +0.09%
==========================================
Files 51 51
Lines 4182 4182
==========================================
+ Hits 3209 3213 +4
+ Misses 973 969 -4 |
fingolfin
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests
pass only if the FGA package was already loaded before the tests, which is the case in usual installations.
If one starts GAP without packages (
-Aoption) then the second test fails. One has to load the package in order to be sure thatlocate_packagereturns a nonempty result.