Provide a stale_age to mkpidlock #1021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1021 +/- ##
==========================================
+ Coverage 75.77% 76.78% +1.00%
==========================================
Files 51 51
Lines 4182 4182
==========================================
+ Hits 3169 3211 +42
+ Misses 1013 971 -42
|
|
There is another call of |
fingolfin
force-pushed
the
mh/mkpidlock-stale_age
branch
from
e1695e2
to
904d046
Compare
Normally the pidlock should be held for a short duration; waiting for its age to exceed the given limits of 10 seconds (for the fake gaproot, which normally finishes in milliseconds) resp. 300 seconds (for installing packages, which only takes a few seconds for most, but a few bad ones can take minutes) until we consider it stale should be safe in each use case. In fact Julia waits 5 times longer if the process creating the pid lock file seems to be still running. On the other hand, without a stale age, the lock file is *never* considered stale, even if the process creating it definitely is gone, and so the user can get stuck, which obviously is very bad. To get unstuck they need to manually delete the lock file.
fingolfin
force-pushed
the
mh/mkpidlock-stale_age
branch
from
904d046
to
45cf72f
Compare
|
@ThomasBreuer ah I somehow missed that one. I've now adjusted it as well but with a higher timeout (5 minutes resp. 25 minutes if the process creating the lock file is still running) |
lgoettgens
approved these changes
Aug 21, 2024
ThomasBreuer
approved these changes
Aug 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normally the pidlock should be held for just a few milliseconds; waiting for its age to exceed 10 seconds until we consider it stale should be very safe. In fact Julia waits 5 times longer if the process creating the pid lock file seems to be still running.
On the other hand, without a stale age, the lock file is never considered stale, even if the process creating it definitely is gone, and so the user can get stuck, which obviously is very bad. To get unstuck they need to manually delete the lock file.