Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: updates issue templates to remove render markdown #14

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

jpower432
Copy link
Member

@jpower432 jpower432 commented Nov 25, 2024

Description

After the initial merge of #5, created a PR with some fixes after testing in the repo.

  • Fixes issue with rendering on feature issue template.
  • Creating some updated based on the behavior and to creating uniformity.

Issue found when creating issue #13. Completion criteria should not be rendered in a markdown snippet.

Verified bug template through #15

How has this been tested?

N/A

Types of changes

  • Hot fix (emergency fix and release)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation (change which affects the documentation site)
  • Breaking change (fix or feature that would cause existing functionality to change)

Quality assurance (all should be covered).

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing tests pass locally with my changes
  • All commits are signed-off.

Fixes issue with rendering on issue template

Signed-off-by: Jennifer Power <[email protected]>
@jpower432 jpower432 requested a review from butler54 November 25, 2024 20:11
Copy link
Contributor

@huiwangredhat huiwangredhat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jpower432 jpower432 merged commit 03dfdab into oscal-compass:main Dec 2, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants