chore: adds minor change to indexing component logic

The ruleSet does not need to the map until it is populated Signed-off-by: Jennifer Power <[email protected]>
oscal-compass · Nov 26, 2024 · a1f8a29 · a1f8a29
1 parent cd235ef
commit a1f8a29
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/rules/memory.go b/rules/memory.go
@@ -93,7 +93,6 @@ func (m *MemoryStore) indexComponent(component oscal112.DefinedComponent) Set[st
 		ruleSet, ok := m.nodes[ruleIdProp.Value]
 		if !ok {
 			ruleSet = extensions.RuleSet{}
-			m.nodes[ruleIdProp.Value] = ruleSet
 		}
 
 		// A check may or may not be registered.
@@ -133,7 +132,7 @@ func (m *MemoryStore) indexComponent(component oscal112.DefinedComponent) Set[st
 			m.byCheck[placeholderCheck.ID] = ruleSet.Rule.ID
 		}
 		rules.Add(ruleSet.Rule.ID)
-		m.nodes[ruleIdProp.Value] = ruleSet
+		m.nodes[ruleSet.Rule.ID] = ruleSet
 	}
 	if len(checkIds) != 0 {
 		m.checksByValidationComponent[component.Title] = checkIds