Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set user id for doco pipeline #1769

Merged
merged 2 commits into from
Dec 5, 2024
Merged

fix: set user id for doco pipeline #1769

merged 2 commits into from
Dec 5, 2024

Conversation

butler54
Copy link
Collaborator

@butler54 butler54 commented Dec 4, 2024

Types of changes

  • Hot fix (emergency fix and release)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation (change which affects the documentation site)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Release (develop -> main)

Quality assurance (all should be covered).

  • My code follows the code style of this project.
  • Documentation for my change is up to date?
  • My PR meets testing requirements.
  • All new and existing tests passed.
  • All commits are signed-off.

Summary

Git users need to be set

Key links:

Before you merge

  • Ensure it is a 'squash commit' if not a release.
  • Ensure CI is currently passing
  • Check sonar. If you are working for a fork a maintainer will reach out, if required.

@butler54 butler54 requested a review from a team as a code owner December 4, 2024 00:49
Copy link
Collaborator

@vikas-agarwal76 vikas-agarwal76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jpower432
Copy link
Member

jpower432 commented Dec 4, 2024

@butler54 I did some local testing here and I think we need to add a --push flag to the mike deploy command. Should that be added to this PR?

@jpower432 jpower432 added this to the v3.6.0 milestone Dec 4, 2024
@jpower432 jpower432 mentioned this pull request Dec 5, 2024
11 tasks
Ensures changes are pushed to the gh-pages branch

Signed-off-by: Jennifer Power <[email protected]>
Copy link
Member

@jpower432 jpower432 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jpower432 jpower432 merged commit 6f51549 into develop Dec 5, 2024
14 checks passed
@jpower432 jpower432 deleted the users branch December 5, 2024 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants