Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fixes pipeline failures in docs #1763

Merged
merged 4 commits into from
Dec 3, 2024
Merged

Conversation

jpower432
Copy link
Member

@jpower432 jpower432 commented Dec 2, 2024

Types of changes

  • Hot fix (emergency fix and release)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation (change which affects the documentation site)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Release (develop -> main)

Quality assurance (all should be covered).

  • My code follows the code style of this project.
  • Documentation for my change is up to date?
  • My PR meets testing requirements.
  • All new and existing tests passed.
  • All commits are signed-off.

Summary

This PR fixes the two pipeline failures:

Adds (If this add does not seem super valuable, I can remove from this PR)
- A check in python test workflow where the mike-version script is checked against the environment.

How To Test

The mike-version job should pass

act push -e test-event.json -W .github/workflows/docs-update.yml -j mike-version

test-event.json contains

{
  "ref": "refs/tags/v3.6.0"
}

Key links:

Before you merge

  • Ensure it is a 'squash commit' if not a release.
  • Ensure CI is currently passing
  • Check sonar. If you are working for a fork a maintainer will reach out, if required.

The existing link is no longer reachable and
returns a 404

Signed-off-by: Jennifer Power <[email protected]>
An action/runner bug causes GITHUB_REF to be empty in some instances.
See issue #2788 on actions/runner.

Signed-off-by: Jennifer Power <[email protected]>
@jpower432 jpower432 requested a review from a team as a code owner December 2, 2024 18:26
@jpower432 jpower432 added this to the v3.6.0 milestone Dec 2, 2024
@jpower432 jpower432 marked this pull request as draft December 2, 2024 18:35
Testing locally would be simpler in this case.

Signed-off-by: Jennifer Power <[email protected]>
@jpower432 jpower432 marked this pull request as ready for review December 2, 2024 19:59
@jpower432 jpower432 requested a review from degenaro December 2, 2024 21:47
Copy link
Collaborator

@butler54 butler54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@vikas-agarwal76 vikas-agarwal76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jpower432 jpower432 merged commit a1bc938 into develop Dec 3, 2024
16 checks passed
@jpower432 jpower432 deleted the ci/fix-pipeline-failure branch December 3, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants