-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: correct missing script #1754
Conversation
Signed-off-by: Chris Butler <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@butler54 I did a re-review here. I did some additional local testing of the new script and got an error relating to os.exit()
. Did you mean sys.exit()
?
Side note - I am wondering if having a dry-run option for PR changes to docs would be beneficial to catch these types of errors in CI. Maybe a follow-on type of action?
Signed-off-by: Chris Butler <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Types of changes
develop
->main
)Quality assurance (all should be covered).
Summary
Fixes that the required script was missing. We all miss this in review (whoops)
Key links:
Before you merge