Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct missing script #1754

Merged
merged 5 commits into from
Dec 2, 2024
Merged

fix: correct missing script #1754

merged 5 commits into from
Dec 2, 2024

Conversation

butler54
Copy link
Collaborator

Types of changes

  • Hot fix (emergency fix and release)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation (change which affects the documentation site)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Release (develop -> main)

Quality assurance (all should be covered).

  • My code follows the code style of this project.
  • Documentation for my change is up to date?
  • My PR meets testing requirements.
  • All new and existing tests passed.
  • All commits are signed-off.

Summary

Fixes that the required script was missing. We all miss this in review (whoops)

Key links:

Before you merge

  • Ensure it is a 'squash commit' if not a release.
  • Ensure CI is currently passing
  • Check sonar. If you are working for a fork a maintainer will reach out, if required.

Signed-off-by: Chris Butler <[email protected]>
Copy link
Member

@jpower432 jpower432 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@butler54 butler54 requested a review from a team as a code owner November 19, 2024 21:22
@butler54 butler54 enabled auto-merge (squash) November 21, 2024 03:51
Copy link
Member

@jpower432 jpower432 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@butler54 I did a re-review here. I did some additional local testing of the new script and got an error relating to os.exit(). Did you mean sys.exit()?

Side note - I am wondering if having a dry-run option for PR changes to docs would be beneficial to catch these types of errors in CI. Maybe a follow-on type of action?

scripts/mike_version_parse.py Outdated Show resolved Hide resolved
scripts/mike_version_parse.py Outdated Show resolved Hide resolved
scripts/mike_version_parse.py Outdated Show resolved Hide resolved
Signed-off-by: Chris Butler <[email protected]>
@butler54 butler54 requested a review from jpower432 November 30, 2024 23:12
Copy link
Member

@jpower432 jpower432 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@vikas-agarwal76 vikas-agarwal76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@butler54 butler54 merged commit 605c044 into develop Dec 2, 2024
14 checks passed
@butler54 butler54 deleted the missing-file branch December 2, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants