Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump paramiko from 3.4.0 to 3.5.0 #1705

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 16, 2024

Bumps paramiko from 3.4.0 to 3.5.0.

Commits

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added dependencies python Pull requests that update Python code labels Sep 16, 2024
Copy link
Contributor Author

dependabot bot commented on behalf of github Sep 16, 2024

Dependabot tried to add @oscal-compass/compliance-trestle-maintainers as a reviewer to this PR, but received the following error from GitHub:

POST https://api.github.com/repos/oscal-compass/compliance-trestle/pulls/1705/requested_reviewers: 422 - Reviews may only be requested from collaborators. One or more of the teams you specified is not a collaborator of the oscal-compass/compliance-trestle repository. // See: https://docs.github.com/rest/pulls/review-requests#request-reviewers-for-a-pull-request

Copy link
Member

@jpower432 jpower432 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@butler54 butler54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason why we are pinning it exactly?

Giving a range / minimum would be more appropriate? unless I'm missing something here?

@rahearn
Copy link
Contributor

rahearn commented Dec 9, 2024

This would also fix #1778

@jpower432 jpower432 linked an issue Dec 9, 2024 that may be closed by this pull request
@jpower432
Copy link
Member

@dependabot rebase

Copy link
Contributor Author

dependabot bot commented on behalf of github Dec 9, 2024

Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry!

If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

@jpower432
Copy link
Member

@dependabot recreate

Bumps [paramiko](https://github.com/paramiko/paramiko) from 3.4.0 to 3.5.0.
- [Commits](paramiko/paramiko@3.4.0...3.5.0)

---
updated-dependencies:
- dependency-name: paramiko
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/pip/paramiko-3.5.0 branch from 20fcb55 to e757622 Compare December 9, 2024 18:21
@dependabot dependabot bot requested a review from a team as a code owner December 9, 2024 18:21
@jpower432 jpower432 requested a review from butler54 December 9, 2024 18:23
@jpower432
Copy link
Member

@butler54 Could you please give this another looks so this can close #1778? I think we can address the pinning on #1715. Does that work?

Copy link
Collaborator

@vikas-agarwal76 vikas-agarwal76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jpower432 jpower432 merged commit 9327576 into develop Dec 17, 2024
14 checks passed
@jpower432 jpower432 deleted the dependabot/pip/paramiko-3.5.0 branch December 17, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecation warnings from paramiko
4 participants