Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move to new org #1483

Merged
merged 3 commits into from
Dec 19, 2023
Merged

fix: move to new org #1483

merged 3 commits into from
Dec 19, 2023

Conversation

degenaro
Copy link
Collaborator

github.com/IBM -> github.com/oscal-compass
ibm.github.io -> oscal-compass.github.io

Types of changes

  • Hot fix (emergency fix and release)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation (change which affects the documentation site)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Release (develop -> main)

Quality assurance (all should be covered).

  • My code follows the code style of this project.
  • Documentation for my change is up to date?
  • My PR meets testing requirements.
  • All new and existing tests passed.
  • All commits are signed-off.

Summary

Changes commensurate with new org.

Key links:

Before you merge

  • Ensure it is a 'squash commit' if not a release.
  • Ensure CI is currently passing
  • Check sonar. If you are working for a fork a maintainer will reach out, if required.

Sorry, something went wrong.

github.com/IBM -> github.com/oscal-compass
ibm.github.io -> oscal-compass.github.io

Signed-off-by: Lou DeGenaro <[email protected]>
Signed-off-by: Lou DeGenaro <[email protected]>
@degenaro
Copy link
Collaborator Author

Closes #1482

mkdocs.yml Outdated Show resolved Hide resolved
Signed-off-by: Alejandro Jose Leiva Palomo <[email protected]>
@AleJo2995
Copy link
Collaborator

@vikas-agarwal76 I have address the change you requested plus few other I found that were not addressed yet.

Copy link
Collaborator

@AleJo2995 AleJo2995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I have address Vikas's comments on @degenaro behalf plus added a couple of other misses

@georgalis
Copy link

best I can tell, org-name = and org-remarks = in docs/cli.md also needs update.
the impetus of this change set doesn't appear anywhere, either?

Copy link
Collaborator

@vikas-agarwal76 vikas-agarwal76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
@AleJo2995 Pls. go ahead and merge into develop.

@AleJo2995 AleJo2995 merged commit c456779 into develop Dec 19, 2023
15 checks passed
@AleJo2995 AleJo2995 deleted the fix/we-have-moved branch December 19, 2023 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants