Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding validate template type to author docs command #1465

Merged
merged 3 commits into from
Oct 6, 2023

Conversation

AleJo2995
Copy link
Collaborator

Types of changes

  • Hot fix (emergency fix and release)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Documentation (change which affects the documentation site)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Release (develop -> main)

Quality assurance (all should be covered).

  • My code follows the code style of this project.
  • Documentation for my change is up to date?
  • My PR meets testing requirements.
  • All new and existing tests passed.
  • All commits are signed-off.

Summary

Closes #1464

Key links:

Before you merge

  • Ensure it is a 'squash commit' if not a release.
  • Ensure CI is currently passing
  • Check sonar. If you are working for a fork a maintainer will reach out, if required.

@AleJo2995
Copy link
Collaborator Author

AleJo2995 commented Oct 5, 2023

This is still in draft due to pending demo. Once demo is done with current folder names, I will change them to a more generic folder and file names. e.g a folder, b folder, a, b, c file names instead of what it is now in tests

E.g tests/data/author/docs/arch-design/ssad/mock/arch-design_v1.md will be changed to be more generic

@AleJo2995 AleJo2995 marked this pull request as ready for review October 5, 2023 20:26
Copy link
Member

@mrgadgil mrgadgil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you

@AleJo2995 AleJo2995 merged commit 5289f51 into develop Oct 6, 2023
16 checks passed
@AleJo2995 AleJo2995 deleted the feat/docs-version-template-type branch October 6, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable validate template type parameter for trestle author docs command
2 participants