Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove the ISM_catalog_profile demo #47

Merged
merged 2 commits into from
Jul 3, 2024
Merged

refactor: remove the ISM_catalog_profile demo #47

merged 2 commits into from
Jul 3, 2024

Conversation

Ma1h01
Copy link
Collaborator

@Ma1h01 Ma1h01 commented Jul 2, 2024

Description

Resolved Issue #40

@Ma1h01 Ma1h01 requested a review from AleJo2995 July 2, 2024 19:53
AleJo2995
AleJo2995 requested changes Jul 3, 2024
View reviewed changes
Copy link
Collaborator

@AleJo2995 AleJo2995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to remove the reference from the README as well.

@Ma1h01
Copy link
Collaborator Author

Ma1h01 commented Jul 3, 2024 •
edited
Loading

@AleJo2995
The ISM catalog demo is now removed from the README.

@Ma1h01 Ma1h01 requested a review from AleJo2995 July 3, 2024 15:02
AleJo2995
AleJo2995 approved these changes Jul 3, 2024
View reviewed changes
Copy link
Collaborator

@AleJo2995 AleJo2995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AleJo2995 AleJo2995 merged commit 134ba15 into develop Jul 3, 2024
6 checks passed
@AleJo2995 AleJo2995 deleted the refactor/ISM_catalog_profile branch July 3, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AleJo2995 AleJo2995 AleJo2995 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ma1h01 @AleJo2995