Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/cis controls #38

Merged
merged 2 commits into from
Jul 3, 2024
Merged

Refactor/cis controls #38

merged 2 commits into from
Jul 3, 2024

Conversation

Ma1h01
Copy link
Collaborator

@Ma1h01 Ma1h01 commented Jun 26, 2024

Description

  1. Resolved Make sure compliance-trestle demos are running correctly - Creating a CIS controls catalog from an excel spreadsheet. compliance-trestle#1601.
  2. Updated the README to include descriptive instructions.
  3. Replaced an obsolete method to be in sync with the current version of the trestle.

@Ma1h01 Ma1h01 requested a review from AleJo2995 June 26, 2024 21:05
@AleJo2995
Copy link
Collaborator

Closes #43

AleJo2995
AleJo2995 approved these changes Jul 1, 2024
View reviewed changes
Copy link
Collaborator

@AleJo2995 AleJo2995 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AleJo2995
Copy link
Collaborator

@Ma1h01 Beautifully resolved. You can go ahead and merge when you have the time. Thanks

@AleJo2995 AleJo2995 mentioned this pull request Jul 1, 2024
Open
7 tasks
@AleJo2995 AleJo2995 merged commit cafc19a into develop Jul 3, 2024
6 checks passed
@AleJo2995 AleJo2995 deleted the refactor/CIS_controls branch July 3, 2024 20:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AleJo2995 AleJo2995 AleJo2995 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@Ma1h01 @AleJo2995