Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: update go modules #31

Merged
merged 2 commits into from
Sep 12, 2024

Conversation

yana1205
Copy link
Collaborator

@yana1205 yana1205 commented Sep 5, 2024

Descriptions

I have updated go modules to eliminate vulnerable modules (For some modules, since the signature of functions are changed, I modified the according modifications on the code).

Now the dependant alerts reduced to two alerts (https://github.com/yana1205/compliance-to-policy/security/dependabot).

  • require github.com/docker/docker v24.0.9
  • github.com/hashicorp/go-retryablehttp v0.7.5

These two modules comes from Kyverno module (v1.12.5). The latest commits on Kyverno release-1.12 branch (go.mod) contain these vulnerable modules. I will wait for the next version of Kyverno (v1.12.6) to be released.

Verification

Test passed.

$ make test
go test ./pkg/... -coverprofile cover.out
        github.com/oscal-compass/compliance-to-policy/go/pkg            coverage: 0.0% of statements
        github.com/oscal-compass/compliance-to-policy/go/pkg/decomposer         coverage: 0.0% of statements
ok      github.com/oscal-compass/compliance-to-policy/go/pkg/kyverno    1.037s  coverage: 12.3% of statements
ok      github.com/oscal-compass/compliance-to-policy/go/pkg/ocm        1.386s  coverage: 38.6% of statements
ok      github.com/oscal-compass/compliance-to-policy/go/pkg/oscal      0.539s  coverage: 45.3% of statements
?       github.com/oscal-compass/compliance-to-policy/go/pkg/pvpcommon/template [no test files]
?       github.com/oscal-compass/compliance-to-policy/go/pkg/types/c2pcr        [no test files]
?       github.com/oscal-compass/compliance-to-policy/go/pkg/types/oscal/assessmentresults      [no test files]
?       github.com/oscal-compass/compliance-to-policy/go/pkg/types/internalcompliance   [no test files]
?       github.com/oscal-compass/compliance-to-policy/go/pkg/types/oscal/common [no test files]
?       github.com/oscal-compass/compliance-to-policy/go/pkg/types/oscal        [no test files]
?       github.com/oscal-compass/compliance-to-policy/go/pkg/types/oscal/componentdefinition    [no test files]
?       github.com/oscal-compass/compliance-to-policy/go/pkg/types/placements   [no test files]
?       github.com/oscal-compass/compliance-to-policy/go/pkg/types/policycomposition    [no test files]
?       github.com/oscal-compass/compliance-to-policy/go/pkg/types/report       [no test files]
        github.com/oscal-compass/compliance-to-policy/go/pkg/tables             coverage: 0.0% of statements
        github.com/oscal-compass/compliance-to-policy/go/pkg/types/utils                coverage: 0.0% of statements
        github.com/oscal-compass/compliance-to-policy/go/pkg/pvpcommon          coverage: 0.0% of statements
        github.com/oscal-compass/compliance-to-policy/go/pkg/types/policygenerator              coverage: 0.0% of statements
        github.com/oscal-compass/compliance-to-policy/go/pkg/types/placementdecision            coverage: 0.0% of statements
        github.com/oscal-compass/compliance-to-policy/go/pkg/types/configurationpolicy          coverage: 0.0% of statements
        github.com/oscal-compass/compliance-to-policy/go/pkg/tables/resources           coverage: 0.0% of statements
        github.com/oscal-compass/compliance-to-policy/go/pkg/types/policy               coverage: 0.0% of statements
ok      github.com/oscal-compass/compliance-to-policy/go/pkg/parser     0.492s  coverage: 35.5% of statements
ok      github.com/oscal-compass/compliance-to-policy/go/pkg/policygenerator    0.481s  coverage: 4.3% of statements

Signed-off-by: Takumi Yanagawa <[email protected]>
Signed-off-by: Takumi Yanagawa <[email protected]>
@yana1205 yana1205 assigned yana1205 and unassigned yana1205 Sep 5, 2024
@yuji-watanabe-jp yuji-watanabe-jp merged commit 2b0b410 into oscal-compass:main Sep 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants