Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds markdown linting for consistent community document styling #84

Merged
merged 5 commits into from
Oct 29, 2024

Conversation

jpower432
Copy link
Member

@jpower432 jpower432 commented Oct 3, 2024

What Changed?

  1. Adds a new workflow for markdown linting
  2. Update the proposal workflow for workflow consistency
  3. Updates documents with fixes for issues found by the linter

Changes require two approvals per the GOVERNANCE.md

@jpower432 jpower432 requested review from jflowers and degenaro October 3, 2024 20:57
@jpower432 jpower432 marked this pull request as ready for review October 3, 2024 20:57
@jpower432 jpower432 requested a review from mrgadgil October 3, 2024 20:57
Copy link
Member

@jflowers jflowers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@vikas-agarwal76 vikas-agarwal76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM


Google Group: [oscal-compass](https://groups.google.com/g/oscal-compass)\
[email protected]


##### Chat anytime
### Chat anytime
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe just me, but when I follow link to chat I am prompted to login. Fine. I choose email and get code to enter. Fine. Then I arrive at slack and am prompted to sign in to kubernetes. This is correct?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to reproduce, but I am always directed to CNCF Slack.

Copy link
Contributor

@degenaro degenaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jpower432 jpower432 merged commit 7fbbb01 into main Oct 29, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants