Skip to content

Commit

Permalink
docs: rewords section about CODEOWNERS in MEMBERSHIP.md
Browse files Browse the repository at this point in the history
We want maintainer approval to merge PRs, but not restrict
the ability to merge PRs with the proper approvals

Signed-off-by: Jennifer Power <[email protected]>
  • Loading branch information
jpower432 committed Aug 27, 2024
1 parent 1488536 commit 837241f
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions MEMBERSHIP.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ The following table provides information about the current roles available to th
| Reviewer | Write with merging restricted via CODEOWNERS |
| Maintainer | Maintain |

> Note: Each project will require push restriction branch protection rule to allow only CODEOWNERS to push to default branches.
> Note: Each project will require branch protection rule to require CODEOWNER approval for PRs to default branches. It GitHub this would mean setting the `Require review from Code Owners`.
### Member

Expand Down Expand Up @@ -84,7 +84,7 @@ Any person who meets the requirements may be nominated by a contributor, includi

As a project Reviewer, you have the following responsibilities and privileges:

* You have the permission to approve, but not merge, a PR.
* You have the permission to approve and merge a PR with CODEOWNER approval
* You have permission to label issues and PRs.
* You consistently assign, close, and reopen issues or PRs.
* You actively triage issues and PRs with high quality.
Expand Down

0 comments on commit 837241f

Please sign in to comment.